Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #188

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Update dependencies #188

merged 3 commits into from
Aug 21, 2018

Conversation

zingmane
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 21, 2018

Coverage Status

Coverage remained the same at 95.852% when pulling fa16de8 on updateDependencies into 8244658 on master.

@zingmane zingmane requested a review from alexvetter August 21, 2018 14:30
@alexvetter
Copy link
Collaborator

alexvetter commented Aug 21, 2018

Läuft auch bei mir lokal durch. Habe ./gradlew wrapper && ./gradlew build ausgeführt. Allerdings sagt Git gradle/wrapper/gradle-wrapper.jar hat sich geändert und außerdem bekomme ich folgende Log Message:

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

@alexvetter
Copy link
Collaborator

Bei solchen Änderungen lohnt es sich auch mal wieder die PerformanceTest.scala auszuführen. D.h. dort lokal mal das @Ignore zu entfernen.

@zingmane
Copy link
Member Author

Bzgl. deprecation warning:
Hier hat das shadow plugin noch einen bug --> GradleUp/shadow#336
Es gibt einen workoround, aber der nutzt das alte plugin handling und ist nicht schön. Das können wir abwarten bis gradle5 kommt.

PerformanceTests liefern nahezu identische Ergebnisse:

vor dep update:

=====
10 performance tests with 2000 rows took 777 ms in average
=====

nach dep update:

=====
10 performance tests with 2000 rows took 772 ms in average
=====

@zingmane zingmane merged commit 28346d3 into master Aug 21, 2018
@zingmane zingmane deleted the updateDependencies branch August 21, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants